feat: refactor wrap_install_command to utilize shell script path detection
This commit is contained in:
+28
-2
@@ -1,6 +1,7 @@
|
||||
//! Fakeroot support for running commands as pseudo-root
|
||||
//! Uses the system fakeroot command when not running as root
|
||||
|
||||
use std::fs;
|
||||
use std::path::Path;
|
||||
use std::process::Command;
|
||||
|
||||
@@ -12,15 +13,40 @@ pub fn is_root() -> bool {
|
||||
/// Wrap a command for fakeroot execution
|
||||
/// For make install, we use the system fakeroot command
|
||||
pub fn wrap_install_command(program: &str, destdir: &Path) -> Command {
|
||||
let script_path = shell_script_path(program);
|
||||
if is_root() {
|
||||
Command::new(program)
|
||||
build_command(program, script_path.as_deref())
|
||||
} else {
|
||||
// Use system fakeroot command which handles LD_PRELOAD internally
|
||||
let mut cmd = Command::new("fakeroot");
|
||||
cmd.arg("--");
|
||||
cmd.arg(program);
|
||||
if let Some(script_path) = script_path.as_deref() {
|
||||
cmd.arg("sh");
|
||||
cmd.arg(script_path);
|
||||
} else {
|
||||
cmd.arg(program);
|
||||
}
|
||||
// Fakeroot will ensure file ownership appears as root
|
||||
cmd.env("DESTDIR", destdir);
|
||||
cmd
|
||||
}
|
||||
}
|
||||
|
||||
fn build_command(program: &str, script_path: Option<&Path>) -> Command {
|
||||
if let Some(script_path) = script_path {
|
||||
let mut cmd = Command::new("sh");
|
||||
cmd.arg(script_path);
|
||||
cmd
|
||||
} else {
|
||||
Command::new(program)
|
||||
}
|
||||
}
|
||||
|
||||
fn shell_script_path(program: &str) -> Option<&Path> {
|
||||
let path = Path::new(program);
|
||||
if !path.is_absolute() && path.components().count() <= 1 {
|
||||
return None;
|
||||
}
|
||||
let bytes = fs::read(path).ok()?;
|
||||
bytes.starts_with(b"#!").then_some(path)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user